[llvm-remarkutil] Make invalid states un-representable in the count tool #140829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ool. This consolidates some of the error handling around regex arguments to the tool, and sets up the APIs such that errors must be handled before their usage.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tobias-stadler
approved these changes
May 28, 2025
Contributor
tobias-stadler
left a comment
tobias-stadler
left a comment
There was a problem hiding this comment.
LGTM, Thanks for refactoring this.
svkeerthy
pushed a commit
that referenced
this pull request
May 29, 2025
…ool (#140829) This consolidates some of the error handling around regex arguments to the tool, and sets up the APIs such that errors must be handled before their usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates some of the error handling around regex arguments to the tool, and sets up the APIs such that errors must be handled before their usage.